linux-kernel - Re: [PATCH v3 1/4] mtd: lart: Rename partition defines to be prefixed with PART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Dec 2016 08:08:36 +0100
From:   Boris Brezillon <boris.brezillon@...e-electrons.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     linux-arm-kernel@...ts.infradead.org, nicolas.pitre@...aro.org,
        mark.rutland@....com, matt@...eblueprint.co.uk, stefan@...er.ch,
        chris.brandt@...esas.com, linux-mtd@...ts.infradead.org,
        cyrille.pitchen@...el.com, panand@...hat.com, pawel.moll@....com,
        richard@....at, linux@...linux.org.uk, ben@...adent.org.uk,
        vladimir.murzin@....com, keescook@...omium.org, arnd@...db.de,
        labbott@...oraproject.org, jonathan.austin@....com,
        ard.biesheuvel@...aro.org, linux-kernel@...r.kernel.org,
        computersforpeace@...il.com, dwmw2@...radead.org,
        kirill.shutemov@...ux.intel.com, js07.lee@...sung.com
Subject: Re: [PATCH v3 1/4] mtd: lart: Rename partition defines to be
 prefixed with PART_

On Fri,  9 Dec 2016 15:36:25 -0800
Florian Fainelli <f.fainelli@...il.com> wrote:

> In preparation for defining KERNEL_START on ARM, rename KERNEL_START to
> PART_KERNEL_START, and to be consistent, do this for all
> partition-related constants.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Acked-by: Boris Brezillon <boris.brezillon@...e-electrons.com>

> ---
>  drivers/mtd/devices/lart.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/mtd/devices/lart.c b/drivers/mtd/devices/lart.c
> index 82bd00af5cc3..268aae45b514 100644
> --- a/drivers/mtd/devices/lart.c
> +++ b/drivers/mtd/devices/lart.c
> @@ -75,18 +75,18 @@ static char module_name[] = "lart";
>  
>  /* blob */
>  #define NUM_BLOB_BLOCKS		FLASH_NUMBLOCKS_16m_PARAM
> -#define BLOB_START			0x00000000
> -#define BLOB_LEN			(NUM_BLOB_BLOCKS * FLASH_BLOCKSIZE_PARAM)
> +#define PART_BLOB_START		0x00000000
> +#define PART_BLOB_LEN		(NUM_BLOB_BLOCKS * FLASH_BLOCKSIZE_PARAM)
>  
>  /* kernel */
>  #define NUM_KERNEL_BLOCKS	7
> -#define KERNEL_START		(BLOB_START + BLOB_LEN)
> -#define KERNEL_LEN			(NUM_KERNEL_BLOCKS * FLASH_BLOCKSIZE_MAIN)
> +#define PART_KERNEL_START	(PART_BLOB_START + PART_BLOB_LEN)
> +#define PART_KERNEL_LEN		(NUM_KERNEL_BLOCKS * FLASH_BLOCKSIZE_MAIN)
>  
>  /* initial ramdisk */
>  #define NUM_INITRD_BLOCKS	24
> -#define INITRD_START		(KERNEL_START + KERNEL_LEN)
> -#define INITRD_LEN			(NUM_INITRD_BLOCKS * FLASH_BLOCKSIZE_MAIN)
> +#define PART_INITRD_START	(PART_KERNEL_START + PART_KERNEL_LEN)
> +#define PART_INITRD_LEN		(NUM_INITRD_BLOCKS * FLASH_BLOCKSIZE_MAIN)
>  
>  /*
>   * See section 4.0 in "3 Volt Fast Boot Block Flash Memory" Intel Datasheet
> @@ -587,20 +587,20 @@ static struct mtd_partition lart_partitions[] = {
>  	/* blob */
>  	{
>  		.name	= "blob",
> -		.offset	= BLOB_START,
> -		.size	= BLOB_LEN,
> +		.offset	= PART_BLOB_START,
> +		.size	= PART_BLOB_LEN,
>  	},
>  	/* kernel */
>  	{
>  		.name	= "kernel",
> -		.offset	= KERNEL_START,		/* MTDPART_OFS_APPEND */
> -		.size	= KERNEL_LEN,
> +		.offset	= PART_KERNEL_START,	/* MTDPART_OFS_APPEND */
> +		.size	= PART_KERNEL_LEN,
>  	},
>  	/* initial ramdisk / file system */
>  	{
>  		.name	= "file system",
> -		.offset	= INITRD_START,		/* MTDPART_OFS_APPEND */
> -		.size	= INITRD_LEN,		/* MTDPART_SIZ_FULL */
> +		.offset	= PART_INITRD_START,	/* MTDPART_OFS_APPEND */
> +		.size	= PART_INITRD_LEN,	/* MTDPART_SIZ_FULL */
>  	}
>  };
>  #define NUM_PARTITIONS ARRAY_SIZE(lart_partitions)