linux-kernel - Re: [PATCH v2 1/2] iio: adc: hx711: Add DT binding for avia,hx711

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Dec 2016 11:34:55 +0100
From:   Andreas Klinger <ak@...klinger.de>
To:     Lars-Peter Clausen <lars@...afoo.de>
Cc:     devicetree@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        pawel.moll@....com, mark.rutland@....com,
        ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
        jic23@...nel.org, knaack.h@....de, pmeerw@...erw.net
Subject: Re: [PATCH v2 1/2] iio: adc: hx711: Add DT binding for avia,hx711

Hi Lars-Peter,

Lars-Peter Clausen <lars@...afoo.de> schrieb am Wed, 14. Dec 11:11:
> On 12/14/2016 10:59 AM, Andreas Klinger wrote:
> > Add DT bindings for avia,hx711
> > Add vendor avia to vendor list
> > 
> > Signed-off-by: Andreas Klinger <ak@...klinger.de>
> > ---
> >  .../devicetree/bindings/iio/adc/avia-hx711.txt      | 21 +++++++++++++++++++++
> >  .../devicetree/bindings/vendor-prefixes.txt         |  1 +
> >  2 files changed, 22 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
> > new file mode 100644
> > index 000000000000..6a4659fc7a4f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
> > @@ -0,0 +1,21 @@
> > +* AVIA HX711 ADC chip for weight cells
> > +  Bit-banging driver
> > +
> > +Required properties:
> > + - compatible: Should be "avia,hx711"
> > + - sck-gpios:	Definition of the GPIO for the clock
> > + - dout-gpios:	Definition of the GPIO for data-out
> > +		See Documentation/devicetree/bindings/gpio/gpio.txt
> > +
> > +Recommended properties:
> > + - gain:	Gain select, can be 32, 64 or 128
> > +		default is 128
> 
> If the gain is software programmable it should be exposed by the driver
> allowing the application to change it rather than putting it in the devicetree.
> 
There is also a hardware dependency in terms of where to connect the input
channel to:
- gain 64 and gain 128 are available only on input channel A
- gain 32 is only available on input channel B

Do you still think, it should be removed from the devicetree?

Andreas
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html