linux-kernel - Re: [PATCH v2 2/3] power: supply: bq24735-charger: optionally poll the ac-detect gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161214151026.5q6goxlfscv53tol@earth>
Date:   Wed, 14 Dec 2016 16:10:27 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     Peter Rosin <peda@...ntia.se>
Cc:     linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/3] power: supply: bq24735-charger: optionally poll
 the ac-detect gpio

Hi,

On Wed, Dec 14, 2016 at 12:56:44AM +0100, Peter Rosin wrote:
> If the ac-detect gpio does not support interrupts, provide a fallback
> to poll the gpio at a configurable interval.
> 
> Signed-off-by: Peter Rosin <peda@...ntia.se>
> ---
>
> [...]
>
> +	} else if (charger->status_gpio) {
> +		ret = of_property_read_u32(client->dev.of_node,
> +					   "poll-interval",
> +					   &charger->poll_interval);

Please use device_property_read_u32() instead.

> [...]

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)