linux-kernel - Re: [PATCH 4.4 01/16] powerpc/eeh: Fix deadlock when PE frozen state cant be cleared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161214010140.GC1141@kroah.com>
Date:   Tue, 13 Dec 2016 17:01:40 -0800
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Andrew Donnellan <andrew.donnellan@....ibm.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Pradipta Ghosh <pradghos@...ibm.com>,
        Russell Currey <ruscur@...sell.cc>,
        Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH 4.4 01/16] powerpc/eeh: Fix deadlock when PE frozen state
 cant be cleared

On Wed, Dec 14, 2016 at 10:59:32AM +1100, Andrew Donnellan wrote:
> On 14/12/16 04:15, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Andrew Donnellan <andrew.donnellan@....ibm.com>
> > 
> > commit 409bf7f8a02ef88db5a0f2cdcf9489914f4b8508 upstream.
> > 
> > In eeh_reset_device(), we take the pci_rescan_remove_lock immediately after
> > after we call eeh_reset_pe() to reset the PCI controller. We then call
> > eeh_clear_pe_frozen_state(), which can return an error. In this case, we
> > bail out of eeh_reset_device() without calling pci_unlock_rescan_remove().
> > 
> > Add a call to pci_unlock_rescan_remove() in the eeh_clear_pe_frozen_state()
> > error path so that we don't cause a deadlock later on.
> > 
> > Reported-by: Pradipta Ghosh <pradghos@...ibm.com>
> > Fixes: 78954700631f ("powerpc/eeh: Avoid I/O access during PE reset")
> > Signed-off-by: Andrew Donnellan <andrew.donnellan@....ibm.com>
> > Acked-by: Russell Currey <ruscur@...sell.cc>
> > Signed-off-by: Michael Ellerman <mpe@...erman.id.au>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> It seems that something in your scripts munged the apostrophe in the summary
> line when generating these emails. Though it looks fine in the actual tree.

Odd, the original patch has the subject right, so git will do it
correctly when it commits the patch.  But, something dropped the '
character when the email was created.  Given that it goes through quilt
a few different ways to get here to the mailing list, I'll blame it :)

thanks,

greg k-h