linux-kernel - Re: [PATCH] MIPS: NI 169445 board support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqJPkVBbvTonOADsu-uaH0bxtNDBJ3OrzE=7vP5pc92H=Q@mail.gmail.com>
Date:   Wed, 14 Dec 2016 10:48:58 -0600
From:   Rob Herring <robh@...nel.org>
To:     Nathan Sullivan <nathan.sullivan@...com>
Cc:     Ralf Baechle <ralf@...ux-mips.org>,
        Mark Rutland <mark.rutland@....com>,
        Linux-MIPS <linux-mips@...ux-mips.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] MIPS: NI 169445 board support

On Wed, Dec 14, 2016 at 10:32 AM, Nathan Sullivan
<nathan.sullivan@...com> wrote:
> On Fri, Dec 09, 2016 at 03:18:28PM -0600, Rob Herring wrote:
>> On Fri, Dec 02, 2016 at 09:42:09AM -0600, Nathan Sullivan wrote:
>> > Support the National Instruments 169445 board.
>> >
>> > Signed-off-by: Nathan Sullivan <nathan.sullivan@...com>
>> > ---
>> > "gpio: mmio: add support for NI 169445 NAND GPIO" and
>> > "devicetree: add vendor prefix for National Instruments" are required for the
>> > NAND on this board to work.

>> > +   ahb@0 {
>> > +           compatible = "simple-bus";
>> > +           #address-cells = <1>;
>> > +           #size-cells = <1>;
>> > +           ranges;
>>
>> If everything is under 0x1f3xxxxx, then add in the ranges here (and the
>> unit address).
>>
>
> I noticed that some systems call out their axi/ahb busses, some do not.  Would
> you prefer that I remove the bus entirely?

Definitely not. IMO, not having a bus node is an error.

Rob