linux-kernel - Re: [v1] video:fbdev:cobalt_lcdfb:- Handle return NULL error from devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACBHAezjGxyP1KVWuHf7oYSF_mTTnPFaDnphAXk7c0N3e3qqzA@mail.gmail.com>
Date:   Wed, 14 Dec 2016 11:23:07 +0900
From:   Yuasa Yoichi <yuasa@...ux-mips.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     tomi.valkeinen@...com, ralf@...ux-mips.org, paul.burton@...tec.com,
        linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [v1] video:fbdev:cobalt_lcdfb:- Handle return NULL error from devm_ioremap

Hi Arvind,

Thank you for fixing it.

Acked-by: Yoichi Yuasa <yuasa@...ux-mips.org>

2016-12-13 17:20 GMT+09:00 Arvind Yadav <arvind.yadav.cs@...il.com>:
> Here, If devm_ioremap will fail. It will return NULL.
> Kernel can run into a NULL-pointer dereference.
> This error check will avoid NULL pointer dereference.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/video/fbdev/cobalt_lcdfb.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/video/fbdev/cobalt_lcdfb.c b/drivers/video/fbdev/cobalt_lcdfb.c
> index 2d3b691..038ac69 100644
> --- a/drivers/video/fbdev/cobalt_lcdfb.c
> +++ b/drivers/video/fbdev/cobalt_lcdfb.c
> @@ -308,6 +308,11 @@ static int cobalt_lcdfb_probe(struct platform_device *dev)
>         info->screen_size = resource_size(res);
>         info->screen_base = devm_ioremap(&dev->dev, res->start,
>                                          info->screen_size);
> +       if (!info->screen_base) {
> +               framebuffer_release(info);
> +               return -ENOMEM;
> +       }
> +
>         info->fbops = &cobalt_lcd_fbops;
>         info->fix = cobalt_lcdfb_fix;
>         info->fix.smem_start = res->start;
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html