lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <201612141056.tpfStCdv%fengguang.wu@intel.com>
Date:   Wed, 14 Dec 2016 10:47:31 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Holger Dengler <dengler@...utronix.de>
Cc:     kbuild-all@...org, Lee Jones <lee.jones@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Vinod Koul <vinod.koul@...el.com>,
        linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Sebastian Siewior <bigeasy@...utronix.de>,
        Juergen Bubeck <bubeck@...ug.com>,
        Peter Mahler <mahler@...ug.com>,
        Holger Dengler <dengler@...utronix.de>,
        Benedikt Spranger <b.spranger@...utronix.de>
Subject: Re: [PATCH 04/12] mfd: flexcard: add interrupt support

Hi Holger,

[auto build test ERROR on char-misc/char-misc-testing]
[also build test ERROR on v4.9]
[cannot apply to ljones-mfd/for-mfd-next next-20161213]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Holger-Dengler/Eberspaecher-Flexcard-PMC-II-base-support/20161214-082350
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All error/warnings (new ones prefixed by >>):

   drivers/mfd/flexcard_irq.c: In function 'flexcard_demux':
>> drivers/mfd/flexcard_irq.c:111:3: error: implicit declaration of function 'generic_handle_irq' [-Werror=implicit-function-declaration]
      generic_handle_irq(cur);
      ^~~~~~~~~~~~~~~~~~
   drivers/mfd/flexcard_irq.c: In function 'flexcard_irq_ack':
>> drivers/mfd/flexcard_irq.c:119:33: error: implicit declaration of function 'irq_data_get_irq_chip_data' [-Werror=implicit-function-declaration]
     struct flexcard_device *priv = irq_data_get_irq_chip_data(d);
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/mfd/flexcard_irq.c:119:33: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
>> drivers/mfd/flexcard_irq.c:120:51: error: dereferencing pointer to incomplete type 'struct irq_data'
     const struct fc_irq_tab *tp = &flexcard_irq_tab[d->hwirq];
                                                      ^~
   drivers/mfd/flexcard_irq.c: In function 'flexcard_irq_mask':
   drivers/mfd/flexcard_irq.c:128:33: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
     struct flexcard_device *priv = irq_data_get_irq_chip_data(d);
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/mfd/flexcard_irq.c: In function 'flexcard_irq_unmask':
   drivers/mfd/flexcard_irq.c:141:33: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
     struct flexcard_device *priv = irq_data_get_irq_chip_data(d);
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/mfd/flexcard_irq.c: At top level:
>> drivers/mfd/flexcard_irq.c:175:15: error: variable 'flexcard_irq_chip' has initializer but incomplete type
    static struct irq_chip flexcard_irq_chip = {
                  ^~~~~~~~
>> drivers/mfd/flexcard_irq.c:176:2: error: unknown field 'name' specified in initializer
     .name  = "flexcard_irq",
     ^
>> drivers/mfd/flexcard_irq.c:176:11: warning: excess elements in struct initializer
     .name  = "flexcard_irq",
              ^~~~~~~~~~~~~~
   drivers/mfd/flexcard_irq.c:176:11: note: (near initialization for 'flexcard_irq_chip')
>> drivers/mfd/flexcard_irq.c:177:2: error: unknown field 'irq_ack' specified in initializer
     .irq_ack = flexcard_irq_ack,
     ^
   drivers/mfd/flexcard_irq.c:177:13: warning: excess elements in struct initializer
     .irq_ack = flexcard_irq_ack,
                ^~~~~~~~~~~~~~~~
   drivers/mfd/flexcard_irq.c:177:13: note: (near initialization for 'flexcard_irq_chip')
>> drivers/mfd/flexcard_irq.c:178:2: error: unknown field 'irq_mask' specified in initializer
     .irq_mask = flexcard_irq_mask,
     ^
   drivers/mfd/flexcard_irq.c:178:14: warning: excess elements in struct initializer
     .irq_mask = flexcard_irq_mask,
                 ^~~~~~~~~~~~~~~~~
   drivers/mfd/flexcard_irq.c:178:14: note: (near initialization for 'flexcard_irq_chip')
>> drivers/mfd/flexcard_irq.c:179:2: error: unknown field 'irq_unmask' specified in initializer
     .irq_unmask = flexcard_irq_unmask,
     ^
   drivers/mfd/flexcard_irq.c:179:16: warning: excess elements in struct initializer
     .irq_unmask = flexcard_irq_unmask,
                   ^~~~~~~~~~~~~~~~~~~
   drivers/mfd/flexcard_irq.c:179:16: note: (near initialization for 'flexcard_irq_chip')
   drivers/mfd/flexcard_irq.c: In function 'flexcard_irq_domain_map':
>> drivers/mfd/flexcard_irq.c:187:2: error: implicit declaration of function 'irq_set_chip_and_handler_name' [-Werror=implicit-function-declaration]
     irq_set_chip_and_handler_name(irq, &flexcard_irq_chip,
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/mfd/flexcard_irq.c:188:11: error: 'handle_level_irq' undeclared (first use in this function)
              handle_level_irq, "flexcard");
              ^~~~~~~~~~~~~~~~
   drivers/mfd/flexcard_irq.c:188:11: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/mfd/flexcard_irq.c:189:2: error: implicit declaration of function 'irq_set_chip_data' [-Werror=implicit-function-declaration]
     irq_set_chip_data(irq, priv);
     ^~~~~~~~~~~~~~~~~
>> drivers/mfd/flexcard_irq.c:190:2: error: implicit declaration of function 'irq_modify_status' [-Werror=implicit-function-declaration]
     irq_modify_status(irq, IRQ_NOREQUEST | IRQ_NOAUTOEN, IRQ_NOPROBE);
     ^~~~~~~~~~~~~~~~~
>> drivers/mfd/flexcard_irq.c:190:25: error: 'IRQ_NOREQUEST' undeclared (first use in this function)
     irq_modify_status(irq, IRQ_NOREQUEST | IRQ_NOAUTOEN, IRQ_NOPROBE);
                            ^~~~~~~~~~~~~
>> drivers/mfd/flexcard_irq.c:190:41: error: 'IRQ_NOAUTOEN' undeclared (first use in this function)
     irq_modify_status(irq, IRQ_NOREQUEST | IRQ_NOAUTOEN, IRQ_NOPROBE);
                                            ^~~~~~~~~~~~
>> drivers/mfd/flexcard_irq.c:190:55: error: 'IRQ_NOPROBE' undeclared (first use in this function)
     irq_modify_status(irq, IRQ_NOREQUEST | IRQ_NOAUTOEN, IRQ_NOPROBE);
                                                          ^~~~~~~~~~~
   drivers/mfd/flexcard_irq.c: At top level:
>> drivers/mfd/flexcard_irq.c:175:24: error: storage size of 'flexcard_irq_chip' isn't known
    static struct irq_chip flexcard_irq_chip = {
                           ^~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/generic_handle_irq +111 drivers/mfd/flexcard_irq.c

   105	
   106		stat = readl(&priv->bar0->conf.irs) & VALID_DEVIRQ_MSK;
   107		while (stat) {
   108			slot = __ffs(stat);
   109			stat &= (1 << slot);
   110			cur = irq_linear_revmap(priv->irq_domain, slot);
 > 111			generic_handle_irq(cur);
   112			ret = IRQ_HANDLED;
   113		}
   114		return ret;
   115	}
   116	
   117	static void flexcard_irq_ack(struct irq_data *d)
   118	{
 > 119		struct flexcard_device *priv = irq_data_get_irq_chip_data(d);
 > 120		const struct fc_irq_tab *tp = &flexcard_irq_tab[d->hwirq];
   121		void __iomem *p = (void __iomem *)priv->bar0 + tp->ackoffs;
   122	
   123		writel(tp->ack, p);
   124	}
   125	
   126	static void flexcard_irq_mask(struct irq_data *d)
   127	{
 > 128		struct flexcard_device *priv = irq_data_get_irq_chip_data(d);
   129		const struct fc_irq_tab *tp = &flexcard_irq_tab[d->hwirq];
   130		void __iomem *p = (void __iomem *)priv->bar0 + tp->mskoffs;
   131		u32 *msk = (void *)priv + tp->mskcache;
   132	
   133		raw_spin_lock(&priv->irq_lock);
   134		*msk &= ~tp->msk;
   135		writel(*msk, p);
   136		raw_spin_unlock(&priv->irq_lock);
   137	}
   138	
   139	static void flexcard_irq_unmask(struct irq_data *d)
   140	{
 > 141		struct flexcard_device *priv = irq_data_get_irq_chip_data(d);
   142		const struct fc_irq_tab *tp = &flexcard_irq_tab[d->hwirq];
   143		void __iomem *p = (void __iomem *)priv->bar0 + tp->mskoffs;
   144		u32 *msk = (void *)priv + tp->mskcache;
   145	
   146		raw_spin_lock(&priv->irq_lock);
   147		*msk |= tp->msk;
   148		writel(*msk, p);
   149		raw_spin_unlock(&priv->irq_lock);
   150	}
   151	
   152	static int flexcard_req_irq(struct pci_dev *pdev)
   153	{
   154		struct flexcard_device *priv = pci_get_drvdata(pdev);
   155		int ret;
   156	
   157		ret = pci_enable_msi(pdev);
   158		if (ret) {
   159			dev_warn(&pdev->dev, "could not enable MSI\n");
   160			/* shared PCI irq fallback */
   161			return request_irq(pdev->irq, flexcard_demux,
   162					   IRQF_NO_THREAD | IRQF_SHARED,
   163					   "flexcard", priv);
   164		}
   165		dev_info(&pdev->dev, "MSI enabled\n");
   166	
   167		ret = request_irq(pdev->irq, flexcard_demux, IRQF_NO_THREAD,
   168				  "flexcard", priv);
   169		if (ret)
   170			pci_disable_msi(pdev);
   171	
   172		return ret;
   173	}
   174	
 > 175	static struct irq_chip flexcard_irq_chip = {
 > 176		.name		= "flexcard_irq",
 > 177		.irq_ack	= flexcard_irq_ack,
 > 178		.irq_mask	= flexcard_irq_mask,
 > 179		.irq_unmask	= flexcard_irq_unmask,
   180	};
   181	
   182	static int flexcard_irq_domain_map(struct irq_domain *d, unsigned int irq,
   183					   irq_hw_number_t hw)
   184	{
   185		struct flexcard_device *priv = d->host_data;
   186	
 > 187		irq_set_chip_and_handler_name(irq, &flexcard_irq_chip,
 > 188					      handle_level_irq, "flexcard");
 > 189		irq_set_chip_data(irq, priv);
 > 190		irq_modify_status(irq, IRQ_NOREQUEST | IRQ_NOAUTOEN, IRQ_NOPROBE);
   191	
   192		return 0;
   193	}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (59495 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ