linux-kernel - [PATCH] x86/crash: Update the stale comment in reserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1481772621-17923-1-git-send-email-xlpang@redhat.com>
Date:   Thu, 15 Dec 2016 11:30:21 +0800
From:   Xunlei Pang <xlpang@...hat.com>
To:     kexec@...ts.infradead.org
Cc:     linux-kernel@...r.kernel.org, Xunlei Pang <xlpang@...hat.com>,
        Robert LeBlanc <robert@...lancnet.us>,
        Baoquan He <bhe@...hat.com>
Subject: [PATCH] x86/crash: Update the stale comment in reserve_crashkernel()

CRASH_KERNEL_ADDR_MAX was missing for a long time, update it
with more detailed explanation.

Cc: Robert LeBlanc <robert@...lancnet.us>
Cc: Baoquan He <bhe@...hat.com>
Signed-off-by: Xunlei Pang <xlpang@...hat.com>
---
 arch/x86/kernel/setup.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 9c337b0..79ee507 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -575,7 +575,10 @@ static void __init reserve_crashkernel(void)
 	/* 0 means: find the address automatically */
 	if (crash_base <= 0) {
 		/*
-		 *  kexec want bzImage is below CRASH_KERNEL_ADDR_MAX
+		 * Set CRASH_ADDR_LOW_MAX upper bound for crash range
+		 * as old kexec-tools loads bzImage below that, unless
+		 * "size,high" or "size@...set"(nonzero offset, see the
+		 * else leg below) is specified.
 		 */
 		crash_base = memblock_find_in_range(CRASH_ALIGN,
 						    high ? CRASH_ADDR_HIGH_MAX
-- 
1.8.3.1