linux-kernel - Re: [PATCH v5 2/2] lockd: change the proc_handler for nsm_use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <cd444c70-0ebe-04df-a990-c606b9ec6ce0@linux.vnet.ibm.com>
Date:   Thu, 15 Dec 2016 16:11:56 +0800
From:   Pan Xinhui <xinhui@...ux.vnet.ibm.com>
To:     Jia He <hejianet@...il.com>, linux-nfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     "Eric W. Biederman" <ebiederm@...ssion.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Serge Hallyn <serge@...lyn.com>,
        "David S. Miller" <davem@...emloft.net>,
        Alexey Dobriyan <adobriyan@...il.com>,
        Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Kees Cook <keescook@...omium.org>,
        Hugh Dickins <hughd@...gle.com>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Daniel Cashman <dcashman@...gle.com>,
        Arnd Bergmann <arnd@...db.de>,
        "J. Bruce Fields" <bfields@...ldses.org>,
        Jeff Layton <jlayton@...chiereds.net>,
        Trond Myklebust <trond.myklebust@...marydata.com>,
        Anna Schumaker <anna.schumaker@...app.com>
Subject: Re: [PATCH v5 2/2] lockd: change the proc_handler for
 nsm_use_hostnames



在 2016/12/15 15:24, Jia He 写道:
> nsm_use_hostnames is a module parameter and it will be exported to sysctl
> procfs. This is to let user sometimes change it from userspace. But the
> minimal unit for sysctl procfs read/write it sizeof(int).
					^^^is^^^
> In big endian system, the converting from/to  bool to/from int will cause
> error for proc items.
>
> This patch use a new proc_handler proc_dobool to fixe it.
						 ^^^fix^^^	
> Signed-off-by: Jia He <hejianet@...il.com>
> ---
other than that is okay for me.

Reviewed-by: Pan Xinhui <xinhui.pan@...ux.vnet.ibm.com>

>  fs/lockd/svc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
> index fc4084e..bd6fcf9 100644
> --- a/fs/lockd/svc.c
> +++ b/fs/lockd/svc.c
> @@ -561,7 +561,7 @@ static struct ctl_table nlm_sysctls[] = {
>  		.data		= &nsm_use_hostnames,
>  		.maxlen		= sizeof(int),
>  		.mode		= 0644,
> -		.proc_handler	= proc_dointvec,
> +		.proc_handler	= proc_dobool,
>  	},
>  	{
>  		.procname	= "nsm_local_state",
>