linux-kernel - Re: [PATCH] MAINTAINERS: Add printk maintainers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Dec 2016 08:48:15 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MAINTAINERS: Add printk maintainers

On Thu, 15 Dec 2016 11:47:58 +0100
Petr Mladek <pmladek@...e.com> wrote:

> I and Sergey would like to volunteer as printk code maintainers.
> It is a code that everyone is using, various people fix bugs or
> even add features but there is nobody really interested into
> maintaining it.
> 
> I and Sergey have put a lot of effort into understanding the code
> and related problems. We are working on solutions for some long
> term problems. There is a nice summary from the Kernel Summit
> presentation, see https://lwn.net/Articles/705938/
> 
> We have already started to use the gained knowledge and comment
> on other printk-related patches. The official role should help
> us to do it more effectively.
> 
> Our priorities are:
> 
>     + prevent deadlocks (printk_safe patchset, console locks)
>     + prevent softlocks (async printk, console_sem and flushing)
>     + handle other bugs/fixes/features as they come
> 
> with this in mind:
> 
>     + printk is used in different context
>     + need special care in some modes, e.g. oops, panic, suspend
>     + do best effort to store/show messages

Output immediately when they happen too. Perhaps we need a way to
differentiate, "Show now" messages vs "This is info only, delay if
needed".

>     + the code is already pretty complicated and twisted;
>       support clean ups; always think hard if a feature/fix
>       is worth any complication
> 
> Of course, it still will be much appreciated if other people review
> printk patches.

I don't have a problem with you maintaining this, but put me down as a
reviewer:

R:      Steven Rostedt <rostedt@...dmis.org>

> 
> Regarding the workflow. It will be highly appreciated if the patches
> might still go via Andrew's -mm tree at least for 4.10. In the long
> term, we would like to make Andrew's life easier and handle printk
> patches in an own git tree. But we first need to set it up and get
> familiar with the processes.

Maybe Andrew should be a reviewer too. But I'll let him speak for
himself.

But anyway...

Acked-by: Steven Rostedt <rostedt@...dmis.org>


-- Steve

> 
> Signed-off-by: Petr Mladek <pmladek@...e.com>
> ---
>  MAINTAINERS | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c77e3bff262f..d8398bede04e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9728,6 +9728,13 @@ S:	Supported
>  F:	Documentation/preempt-locking.txt
>  F:	include/linux/preempt.h
>  
> +PRINTK
> +M:	Petr Mladek <pmladek@...e.com>
> +M:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> +S:	Maintained
> +F:	kernel/printk/
> +F:	include/linux/printk.h
> +
>  PRISM54 WIRELESS DRIVER
>  M:	"Luis R. Rodriguez" <mcgrof@...il.com>
>  L:	linux-wireless@...r.kernel.org