linux-kernel - Re: [PATCH] staging : osc : Remove braces from single-line body

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+JOspqNxVHU-xJcHhdbG5JvGYp=N1Rcm9hx9c2a1z4z42ffCw@mail.gmail.com>
Date:   Thu, 15 Dec 2016 20:09:16 +0530
From:   Tabrez Khan <khan.tabrez21@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     andreas.dilger@...el.com, jsimmons@...radead.org,
        lustre-devel@...ts.lustre.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging : osc : Remove braces from single-line body

On Thu, Dec 15, 2016 at 7:08 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Thu, Dec 15, 2016 at 07:03:52AM +0530, Tabrez khan wrote:
>> Remove unnecessary braces {} for single if statement block.
>> This warning is found using checkpatch.pl.
>>
>> Signed-off-by: Tabrez khan <khan.tabrez21@...il.com>
>> ---
>>  drivers/staging/lustre/lustre/osc/osc_cache.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/osc/osc_cache.c b/drivers/staging/lustre/lustre/osc/osc_cache.c
>> index 4bbe219..5ded31a 100644
>> --- a/drivers/staging/lustre/lustre/osc/osc_cache.c
>> +++ b/drivers/staging/lustre/lustre/osc/osc_cache.c
>> @@ -1420,10 +1420,8 @@ static void osc_release_write_grant(struct client_obd *cli,
>>                                   struct brw_page *pga)
>>  {
>>       assert_spin_locked(&cli->cl_loi_list_lock);
>> -     if (!(pga->flag & OBD_BRW_FROM_GRANT)) {
>> +     if (!(pga->flag & OBD_BRW_FROM_GRANT))
>>               return;
>> -     }
>> -
>
> Why did you also delete the blank line?

Because to keep the kernel coding style as close as possible and after
deleting brace it leads to extra empty line so i delete it.
Please guide if done something wrong.