linux-kernel - Re: [PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1481818838.1934.2.camel@linux.intel.com>
Date:   Thu, 15 Dec 2016 08:20:38 -0800
From:   Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
To:     Corentin Labbe <clabbe.montjoie@...il.com>, jikos@...nel.org,
        benjamin.tissoires@...hat.com, linux-input@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h
 include

On Thu, 2016-12-15 at 16:27 +0100, Corentin Labbe wrote:
> hid/intel-ish-hid does not use any miscdevice so this patch remove
> this unnecessary inclusion.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>

> ---
>  drivers/hid/intel-ish-hid/ipc/pci-ish.c | 1 -
>  drivers/hid/intel-ish-hid/ishtp/hbm.c   | 1 -
>  drivers/hid/intel-ish-hid/ishtp/init.c  | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> index 20d647d..d20da39 100644
> --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> @@ -24,7 +24,6 @@
>  #include <linux/sched.h>
>  #include <linux/interrupt.h>
>  #include <linux/workqueue.h>
> -#include <linux/miscdevice.h>
>  #define CREATE_TRACE_POINTS
>  #include <trace/events/intel_ish.h>
>  #include "ishtp-dev.h"
> diff --git a/drivers/hid/intel-ish-hid/ishtp/hbm.c
> b/drivers/hid/intel-ish-hid/ishtp/hbm.c
> index 59460b6..b721360 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/hbm.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/hbm.c
> @@ -19,7 +19,6 @@
>  #include <linux/sched.h>
>  #include <linux/wait.h>
>  #include <linux/spinlock.h>
> -#include <linux/miscdevice.h>
>  #include "ishtp-dev.h"
>  #include "hbm.h"
>  #include "client.h"
> diff --git a/drivers/hid/intel-ish-hid/ishtp/init.c
> b/drivers/hid/intel-ish-hid/ishtp/init.c
> index ac36441..d27e035 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/init.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/init.c
> @@ -16,7 +16,6 @@
>  #include <linux/export.h>
>  #include <linux/slab.h>
>  #include <linux/sched.h>
> -#include <linux/miscdevice.h>
>  #include "ishtp-dev.h"
>  #include "hbm.h"
>  #include "client.h"