linux-kernel - Re: [PATCH v4 2/6] [media] rc-main: split setup and unregister functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161215160118.77hz5kuqjmxuotry@jack.zhora.eu>
Date:   Fri, 16 Dec 2016 01:01:18 +0900
From:   Andi Shyti <andi@...zian.org>
To:     Sean Young <sean@...s.org>
Cc:     Andi Shyti <andi.shyti@...sung.com>,
        Mauro Carvalho Chehab <mchehab@....samsung.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Richard Purdie <rpurdie@...ys.net>,
        Jacek Anaszewski <j.anaszewski@...sung.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andi Shyti <andi@...zian.org>
Subject: Re: [PATCH v4 2/6] [media] rc-main: split setup and unregister
 functions

> > +	/* rc_open will be called here */
> > +	rc = input_register_device(dev->input_dev);
> > +	if (rc)
> > +		goto out_table;
> > +
> > +	dev->input_dev->dev.parent = &dev->dev;
> > +	memcpy(&dev->input_dev->id, &dev->input_id, sizeof(dev->input_id));
> > +	dev->input_dev->phys = dev->input_phys;
> > +	dev->input_dev->name = dev->input_name;
> 
> I was testing your changes, and with this patch none of my rc devices
> have input devices associated with them. The problem is that you've changed
> the order: input_register_device() should happen AFTER the preceding
> 4 lines.

This must have been a copy paste error and I don't have
transmitters to test it. Thanks for testing it. I will send it
again.

Andi