linux-kernel - Re: [PATCH v3] dt-bindings: power: supply: bq24735: reverse the polarity of ac-detect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3e87e2b-5d0d-c1ff-8edf-f4a77de31c1e@axentia.se>
Date:   Thu, 15 Dec 2016 18:50:06 +0100
From:   Peter Rosin <peda@...ntia.se>
To:     Stephen Warren <swarren@...dotorg.org>
Cc:     linux-kernel@...r.kernel.org, Sebastian Reichel <sre@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
        Jon Hunter <jonathanh@...dia.com>
Subject: Re: [PATCH v3] dt-bindings: power: supply: bq24735: reverse the
 polarity of ac-detect

On 2016-12-15 18:32, Stephen Warren wrote:
> On 12/15/2016 05:21 AM, Peter Rosin wrote:
>> The ACOK pin on the bq24735 is active-high, of course meaning that when
>> AC is OK the pin is high. However, all Tegra dts files have incorrectly
>> specified active-high even though the signal is inverted on the Tegra
>> boards. This has worked since the Linux driver has also inverted the
>> meaning of the GPIO. Fix this situation by simply specifying in the
>> bindings what everybody else agrees on; that the ti,ac-detect-gpios is
>> active on AC adapter absence.
>>
>> Signed-off-by: Peter Rosin <peda@...ntia.se>
>> ---
>>
>> Hi!
>>
>> This patch is the result of this discussion:
>> http://marc.info/?t=148152531800002
>>
>> I don't like how it changes the one thing that is seems correct, but
>> what to do?
> 
> I haven't followed this thread so hopefully what I say is relevant. My 
> take is:
> 
> If the DT binding is correct or reasonable, keep it.
> 
> If the Tegra DTs contain incorrect content, and never worked correctly 
> in this aspect, then fix them. We do need to maintain DT 
> ABI/compatibility, but I believe only with stuff that actually worked 
> correctly. If the DT has a bug, just fix it.
> 
> That said, if ti,ac-detect-gpios is describing a host GPIO, then it's 
> entirely arbitrary which polarity it should have, i.e. the polarity is 
> not something specified by the bq24735 HW. In that case, feel free to 
> change either the binding to match the DT or the DT to match the 
> binding. Changing the DT to match the binding might still be better 
> since there could be other users you're not aware of, and they might 
> have written their DT correctly, and you don't want to break them.

The bindings are fine.

The Tegra dts files are buggy, but the driver is also buggy, so those
two bugs cancel each other. So, the option is to either introduce
regressions by fixing the two bugs thus creating a flag day where
the kernel and dt needs to match. Or, just document what is going on
and change the bindings even if they are not wrong.

I suggest you read the discussion. We covered all this already, and it
is also in the commit message.

Cheers,
peda