linux-kernel - Re: [PATCH 2/2] media: omap3isp change to devm for resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03073060-1166-7f61-8b3f-287a9f148b40@osg.samsung.com>
Date:   Thu, 15 Dec 2016 15:51:41 -0700
From:   Shuah Khan <shuahkh@....samsung.com>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        sakari.ailus@...ux.intel.com
Cc:     mchehab@...nel.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH 2/2] media: omap3isp change to devm for resources

On 12/15/2016 03:33 PM, Laurent Pinchart wrote:
> Hi Shuah,
> 
> Thank you for the patch.
> 
> Sakari has submitted a similar patch as part of his kref series. Please use it 
> as a base point and rework it if you want to get it merged separately. I've 
> reviewed the patch and left quite a few comments that need to be addressed.
> 

I really don't mind if Sakari uses this patch as is and makes the changes
you requested and submits devm removal as an independent patch.

My intent behind sending this one is to help him out since I already did
this patch that is on top of 4.9-rc8 without any dependencies on Sakari's
RFC patch.

thanks,
-- Shuah

> On Thursday 15 Dec 2016 12:40:08 Shuah Khan wrote:
>> Using devm resources that have external dependencies such as a dev
>> for a file handler could result in devm resources getting released
>> durin unbind while an application has the file open holding pointer
>> to the devm resource. This results in use-after-free errors when the
>> application exits.
>>
>> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
>> ---
>>  drivers/media/platform/omap3isp/isp.c         | 71 ++++++++++++++++--------
>>  drivers/media/platform/omap3isp/ispccp2.c     | 10 +++-
>>  drivers/media/platform/omap3isp/isph3a_aewb.c | 21 +++++---
>>  drivers/media/platform/omap3isp/isph3a_af.c   | 21 +++++---
>>  drivers/media/platform/omap3isp/isphist.c     |  5 +-
>>  5 files changed, 92 insertions(+), 36 deletions(-)
>