linux-kernel - Re: [PATCH] Input: i8042 - force synchronous probing of PNP drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161216085624.GJ13946@wotan.suse.de>
Date:   Fri, 16 Dec 2016 09:56:24 +0100
From:   "Luis R. Rodriguez" <mcgrof@...e.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     linux-input@...r.kernel.org,
        Marcos Paulo de Souza <marcos.souza.org@...il.com>,
        "Luis R. Rodriguez" <mcgrof@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: i8042 - force synchronous probing of PNP drivers

On Tue, Dec 13, 2016 at 09:56:32AM -0800, Dmitry Torokhov wrote:
> We rely on the result of scanning PNP bus for keyboard and mouse devices to
> decide whether we should continue initialization of i8042 driver or not, so
> the probes can not be asynchronous.

Can initializing of i8042 driver happen using a wait for completion ?
If so I'd be happy for the sort of change going in first and then a fix
to enable it so that others can rely on it as an example of how to shy
away from the temporary async probe blacklist.

And is there any grammatical expression which can be used to hunt for similar
types of incompatibilities with async probe ? I'm wondering if one can hunt
for them using for instance Coccinelle SmPL grammar

> Also, it is not a good idea to unbind either of the PNP devices while i8042
> is running, so let's disable bind/unbind for the PNP drivers through sysfs
> and rely on i8042 cleaning after itself properly. User can still unbind and
> rebind entire i8042 and that will take care of PNP drivers as well.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Otherwise:

Reviewed-by: Luis R. Rodriguez <mgrof@...nel.org>

  Luis
> ---
>  drivers/input/serio/i8042-x86ia64io.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
> index 2503d01..79daea84 100644
> --- a/drivers/input/serio/i8042-x86ia64io.h
> +++ b/drivers/input/serio/i8042-x86ia64io.h
> @@ -925,6 +925,10 @@ static struct pnp_driver i8042_pnp_kbd_driver = {
>  	.name           = "i8042 kbd",
>  	.id_table       = pnp_kbd_devids,
>  	.probe          = i8042_pnp_kbd_probe,
> +	.driver         = {
> +		.probe_type = PROBE_FORCE_SYNCHRONOUS,
> +		.suppress_bind_attrs = true,
> +	},
>  };
>  
>  static struct pnp_device_id pnp_aux_devids[] = {
> @@ -947,6 +951,10 @@ static struct pnp_driver i8042_pnp_aux_driver = {
>  	.name           = "i8042 aux",
>  	.id_table       = pnp_aux_devids,
>  	.probe          = i8042_pnp_aux_probe,
> +	.driver         = {
> +		.probe_type = PROBE_FORCE_SYNCHRONOUS,
> +		.suppress_bind_attrs = true,
> +	},
>  };
>  
>  static void i8042_pnp_exit(void)
> -- 
> 2.8.0.rc3.226.g39d4020
> 
> 
> -- 
> Dmitry
> 

-- 
Luis Rodriguez, SUSE LINUX GmbH
Maxfeldstrasse 5; D-90409 Nuernberg