linux-kernel - Re: [PATCH] ARM: imx: remove unused device definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Dec 2016 10:28:48 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Shawn Guo <shawnguo@...nel.org>, linux-kernel@...r.kernel.org,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        Alexander Kurz <akurz@...la.de>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: imx: remove unused device definitions

On 12/16/2016 10:23 AM, Arnd Bergmann wrote:
> On Friday, December 16, 2016 10:10:49 AM CET Marc Kleine-Budde wrote:
>> On 12/16/2016 10:05 AM, Arnd Bergmann wrote:
>>> I stumbled over these during build testing, they are evidently
>>> not referenced anywhere any more.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>>> ---
>>>  arch/arm/mach-imx/devices/platform-flexcan.c         |  9 ---------
>>>  arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c | 10 ----------
>>>  2 files changed, 19 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-imx/devices/platform-flexcan.c b/arch/arm/mach-imx/devices/platform-flexcan.c
>>> index 55d61eaf63c6..8a1a2fc4ce10 100644
>>> --- a/arch/arm/mach-imx/devices/platform-flexcan.c
>>> +++ b/arch/arm/mach-imx/devices/platform-flexcan.c
>>> @@ -19,15 +19,6 @@
>>>  #define imx_flexcan_data_entry(soc, _id, _hwid, _size)			\
>>>  	[_id] = imx_flexcan_data_entry_single(soc, _id, _hwid, _size)
>>>  
>>> -#ifdef CONFIG_SOC_IMX25
>>> -const struct imx_flexcan_data imx25_flexcan_data[] __initconst = {
>>> -#define imx25_flexcan_data_entry(_id, _hwid)				\
>>> -	imx_flexcan_data_entry(MX25, _id, _hwid, SZ_16K)
>>> -	imx25_flexcan_data_entry(0, 1),
>>> -	imx25_flexcan_data_entry(1, 2),
>>> -};
>>> -#endif /* ifdef CONFIG_SOC_IMX25 */
>>> -
>>>  #ifdef CONFIG_SOC_IMX35
>>>  const struct imx_flexcan_data imx35_flexcan_data[] __initconst = {
>>>  #define imx35_flexcan_data_entry(_id, _hwid)				\
>>
>> What about the imx35 variant?
>>
> 
> It's used from here:
> 
> arch/arm/mach-imx/mach-pcm043.c:        imx35_add_flexcan1();

Yes, you're right. Sorry, I searched before my 2nd tee.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)