linux-kernel - Re: [PATCH 3/3] mm: make pagoff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161216105514.GA466@yury-N73SV>
Date:   Fri, 16 Dec 2016 16:25:14 +0530
From:   Yury Norov <ynorov@...iumnetworks.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     <libc-alpha@...rceware.org>,
        "Dr. Philipp Tomsich" <philipp.tomsich@...obroma-systems.com>,
        Catalin Marinas <catalin.marinas@....com>,
        <linux-arch@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
        <szabolcs.nagy@....com>, <heiko.carstens@...ibm.com>,
        <cmetcalf@...hip.com>, "Joseph S. Myers" <joseph@...esourcery.com>,
        <zhouchengming1@...wei.com>,
        "Kapoor, Prasun" <Prasun.Kapoor@...iumnetworks.com>,
        Alexander Graf <agraf@...e.de>, <geert@...ux-m68k.org>,
        <kilobyte@...band.pl>, <manuel.montezelo@...il.com>,
        Andrew Pinski <pinskia@...il.com>, <linyongting@...wei.com>,
        Alexey Klimov <klimov.linux@...il.com>, <broonie@...nel.org>,
        "Zhangjian (Bamvor)" <bamvor.zhangjian@...wei.com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Maxim Kuvyrkov <maxim.kuvyrkov@...aro.org>,
        Nathan Lynch <Nathan_Lynch@...tor.com>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        <davem@...emloft.net>, <christoph.muellner@...obroma-systems.com>
Subject: Re: [PATCH 3/3] mm: make pagoff_t type 64-bit

On Sun, Dec 11, 2016 at 03:59:01PM +0100, Arnd Bergmann wrote:
> On Sunday, December 11, 2016 6:26:42 PM CET Yury Norov wrote:
> > Also fix related interfaces
> > 
> > Signed-off-by: Yury Norov <ynorov@...iumnetworks.com>
> 
> Thanks Yury for the demonstration. I think this would put the nail
> in the coffin of the idea of mmap64 even for Pavel, who didn't
> seem convinced already.
> 
> Changing all those interfaces and structure, struct page in particular,
> is clearly too costly for any advantage we might have otherwise
> gained.
> 
> 	Arnd

To be complete, we have 3 options:
 1 leave things as is. 32-bit architectures will have no option to
   mmap big offsets, and no one cares - as usual.
 2 add mmap64() for compat arches only. This way we don't need patch
   3, and arches like aarch32 or aarch64/ilp32 will enjoy true 64-bit
   offsets.
 3 introduce CONFIG_64_BIT_PGOFF_T, and let Pavel enable it if he has
   to work with big files on 32-bit arches.

The most realistic approach for me is 1 because I never heard about
64-bit pgoff_t requests, except Pavel's one. Thinking about
aarch64/ilp32, we probably need second approach. This is only 2 simple
patches that are already there, and one patch in glibc. It will let
32-bit software work in 64-bit environment more smoothly. Cavium
people should be completely satisfied with 2.

Third is more looking like research exercise than something we need
in practice.

The only thing that makes me sad is that we proudly declare 64-bit
off_t in new 32-bit ABIs but in fact we lie, at least in this
specific case. We should add corresponding checks on glibc side at
least. It's also simple.

Yury.