linux-kernel - Re: [PATCH] perf trace: Check if MAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161216140247.GK6866@kernel.org>
Date:   Fri, 16 Dec 2016 11:02:47 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...nel.org>
Cc:     Kyle McMartin <kyle@...hat.com>, David Ahern <dsahern@...il.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH] perf trace: Check if MAP_32BIT is defined (again)

Em Thu, Dec 15, 2016 at 08:56:54PM +0100, Jiri Olsa escreveu:
> There might be systems where MAP_32BIT is not defined,
> like some some RHEL7 powerpc versions.
> 
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> Cc: Kyle McMartin <kyle@...hat.com>
> Cc: David Ahern <dsahern@...il.com>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Fixes: 277cf08f3feb ("perf trace beauty mmap: Fix defines for non !x86_64")

Ouch, so we need what was removed in:

Fixes: 256763b01741 ("perf trace beauty mmap: Add more conditional defines")

I.e. the ifdef at the switch case entry, not the removal of the
conditional definition expecting that it would be available in the arch
header, as in some cases those are not there. So I'm replacing the Fixme
cset, ok?

Thanks for taking the time to fill in that tag, appreciated!

Also this all needs a revamp to support cross 'perf trace'ing, i.e.
collecting a file on arch A and doing 'perf trace -i perf.data' on a
different machine with a CPU fo a different arch, where either per arch
beautifiers are needed or a dynamic switch, i.e. the value for some
define is different between archs....

Patch applied, thanks,

- Arnaldo


> Link: http://lkml.kernel.org/n/tip-qp5uczb0ln480l47xbv406cw@git.kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> ---
>  tools/perf/trace/beauty/mmap.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/trace/beauty/mmap.c b/tools/perf/trace/beauty/mmap.c
> index fd710ab33684..af1cfde6b97b 100644
> --- a/tools/perf/trace/beauty/mmap.c
> +++ b/tools/perf/trace/beauty/mmap.c
> @@ -42,7 +42,9 @@ static size_t syscall_arg__scnprintf_mmap_flags(char *bf, size_t size,
>  
>  	P_MMAP_FLAG(SHARED);
>  	P_MMAP_FLAG(PRIVATE);
> +#ifdef MAP_32BIT
>  	P_MMAP_FLAG(32BIT);
> +#endif
>  	P_MMAP_FLAG(ANONYMOUS);
>  	P_MMAP_FLAG(DENYWRITE);
>  	P_MMAP_FLAG(EXECUTABLE);
> -- 
> 2.7.4