linux-kernel - Re: [PATCH v3 4/4] p54: convert to sysdata API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161216171451.GX13946@wotan.suse.de>
Date:   Fri, 16 Dec 2016 18:14:51 +0100
From:   "Luis R. Rodriguez" <mcgrof@...nel.org>
To:     "Luis R. Rodriguez" <mcgrof@...nel.org>
Cc:     gregkh@...uxfoundation.org, ming.lei@...onical.com, wagi@...om.org,
        teg@...m.no, mchehab@....samsung.com, zajec5@...il.com,
        linux-kernel@...r.kernel.org, markivx@...eaurora.org,
        stephen.boyd@...aro.org, broonie@...nel.org,
        zohar@...ux.vnet.ibm.com, tiwai@...e.de, johannes@...solutions.net,
        chunkeey@...glemail.com, hauke@...ke-m.de,
        jwboyer@...oraproject.org, dmitry.torokhov@...il.com,
        dwmw2@...radead.org, jslaby@...e.com,
        torvalds@...ux-foundation.org, luto@...capital.net,
        fengguang.wu@...el.com, rpurdie@...ys.net,
        j.anaszewski@...sung.com, Abhay_Salunke@...l.com,
        Julia.Lawall@...6.fr, Gilles.Muller@...6.fr, nicolas.palix@...g.fr,
        dhowells@...hat.com, bjorn.andersson@...aro.org,
        arend.vanspriel@...adcom.com, kvalo@...eaurora.org
Subject: Re: [PATCH v3 4/4] p54: convert to sysdata API

On Fri, Dec 16, 2016 at 03:46:32AM -0800, Luis R. Rodriguez wrote:
> diff --git a/drivers/net/wireless/intersil/p54/p54usb.c b/drivers/net/wireless/intersil/p54/p54usb.c
> index 043bd1c23c19..8870d177b7d5 100644
> --- a/drivers/net/wireless/intersil/p54/p54usb.c
> +++ b/drivers/net/wireless/intersil/p54/p54usb.c
> @@ -959,12 +958,14 @@ static int p54u_load_firmware(struct ieee80211_hw *dev,
>  {
>  	struct usb_device *udev = interface_to_usbdev(intf);
>  	struct p54u_priv *priv = dev->priv;
> +	const struct drvdata_req_params req_params = {
> +		SYSDATA_KEEP_ASYNC(p54u_load_firmware_cb, priv),
> +	};

Whoops forgot to convert here due to the bikeshed, sorry thought I had
compile tested the entire driver... Can send a follow up later after
the other patches get reviewed.

  Luis