linux-kernel - Re: [PATCH v6 2/3] arch/x86/platform/atom: Move pmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161216182045.GA44199@f23x64.localdomain>
Date:   Fri, 16 Dec 2016 10:20:45 -0800
From:   Darren Hart <dvhart@...radead.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Irina Tirdea <irina.tirdea@...el.com>, linux-clk@...r.kernel.org,
        "x86@...nel.org" <x86@...nel.org>,
        platform-driver-x86@...r.kernel.org,
        Stephen Boyd <sboyd@...eaurora.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Michael Turquette <mturquette@...libre.com>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        ALSA Development Mailing List <alsa-devel@...a-project.org>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...el.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 2/3] arch/x86/platform/atom: Move pmc_atom to
 drivers/platform/x86

On Tue, Dec 13, 2016 at 01:43:31AM +0200, Andy Shevchenko wrote:
> I have been told I have to send my comments here instead of our
> internal ML. I didn't fast enough to comment that during v5. So do it
> right now.
> 
> On Fri, Dec 9, 2016 at 8:01 PM, Irina Tirdea <irina.tirdea@...el.com> wrote:
> > The pmc_atom driver does not contain any architecture specific
> > code. It only enables the SOC Power Management Controller Driver
> 
> SOC -> SoC
> Driver -> driver
> 
> > for BayTrail and CherryTrail platforms.
> >
> > Move the pmc_atom driver from arch/x86/platform/atom to
> > drivers/platform/x86.
> >
> > Signed-off-by: Irina Tirdea <irina.tirdea@...el.com>
> > ---
> >  arch/x86/Kconfig                                                     | 4 ----
> >  arch/x86/platform/atom/Makefile                                      | 1 -
> >  drivers/acpi/acpi_lpss.c                                             | 2 +-
> >  drivers/platform/x86/Kconfig                                         | 4 ++++
> >  drivers/platform/x86/Makefile                                        | 1 +
> >  {arch/x86/platform/atom => drivers/platform/x86}/pmc_atom.c          | 3 +--
> 
> >  {arch/x86/include/asm => include/linux/platform_data/x86}/pmc_atom.h | 0
> 
> No, it's not a *platform data*.
> 
> Other that that looks good to me.

Where would you recommend instead? It needs a place to serve both acpi_lpss.c
and pmc_atom.c. The include/linux/platform_data/x86 location doesn't seem too
strange as it supports a "platform" driver in the sense that pmc_atom is a
platform driver.

-- 
Darren Hart
Intel Open Source Technology Center