linux-kernel - Re: [PATCH] gcc-plugin: include memmodel.h and tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKx-dCqzuvNWWW9bi2v2d8Gp1_+UZEYDGwaacJAAnbtyQ@mail.gmail.com>
Date:   Fri, 16 Dec 2016 11:40:16 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Emese Revfy <re.emese@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Kugan <kugan.vivekanandarajah@...aro.org>,
        "# 3.4.x" <stable@...r.kernel.org>, Michal Marek <mmarek@...e.com>,
        "kernel-hardening@...ts.openwall.com" 
        <kernel-hardening@...ts.openwall.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "pageexec@...email.hu" <pageexec@...email.hu>
Subject: Re: [PATCH] gcc-plugin: include memmodel.h and tree_vrp.h for gcc-7

On Fri, Dec 16, 2016 at 6:10 AM, Emese Revfy <re.emese@...il.com> wrote:
> On Fri, 16 Dec 2016 10:00:22 +0100
> Arnd Bergmann <arnd@...db.de> wrote:
>
>> Cc: stable@...r.kernel.org
>> Suggested-by: Kugan <kugan.vivekanandarajah@...aro.org>
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
>>  scripts/gcc-plugins/gcc-common.h | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/scripts/gcc-plugins/gcc-common.h b/scripts/gcc-plugins/gcc-common.h
>> index 950fd2e64bb7..cb4a9518b58a 100644
>> --- a/scripts/gcc-plugins/gcc-common.h
>> +++ b/scripts/gcc-plugins/gcc-common.h
>> @@ -18,6 +18,9 @@
>>
>>  #include "tree-inline.h"
>>  #include "version.h"
>> +#if BUILDING_GCC_VERSION >= 7000
>> +#include "memmodel.h"
>> +#endif
>>  #include "rtl.h"
>>  #include "tm_p.h"
>>  #include "flags.h"
>> @@ -66,6 +69,9 @@
>>  #include "tree-flow.h"
>>  #else
>>  #include "tree-cfgcleanup.h"
>> +#if BUILDING_GCC_VERSION >= 7000
>> +#include "tree-vrp.h"
>> +#endif
>>  #include "tree-ssa-operands.h"
>>  #include "tree-into-ssa.h"
>>  #endif
>
> Hi,
>
> Could you please use the upstream gcc-common.h? You can find it here:
> https://www.grsecurity.net/~paxguy1/gcc-common.h

A bunch of the diff between this and the existing gcc-common.h are
commented out includes. :)

I'll strip out those and send the resulting patch. Thanks!

-Kees

-- 
Kees Cook
Nexus Security