linux-kernel - Re: [PATCH] i2c: i2c-mux-pca954x: only reset last channel on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4214d65e-7146-38e4-cb02-d6c947a51e65@axentia.se>
Date:   Fri, 16 Dec 2016 22:30:11 +0100
From:   Peter Rosin <peda@...ntia.se>
To:     Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:     Wolfram Sang <wsa@...-dreams.de>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com,
        Russell King <rmk+kernel@...linux.org.uk>
Subject: Re: [PATCH] i2c: i2c-mux-pca954x: only reset last channel on error

On 2016-12-16 22:08, Vivien Didelot wrote:
> The current code is selecting the mux channel before each operation and
> does not benefit from the cached value (data->last_chan).
> 
> That is because pca954x_select_chan() considers any non-zero values from
> pca954x_reg_write() as an error. But this function (via __i2c_transfer)
> returns either a negative error code or the positive number of messages
> executed.
> 
> Only check "ret" against negative values to restore the caching.
> 
> Fixes: 463e8f845cbf ("i2c: mux: pca954x: retry updating the mux selection on failure")
> Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

Hi Vivien,

Thanks for the report, and sorry for breaking things. However, your
patch got beaten by an hour by Russel King who sent approximately
the same patch. I had already responded to his message when I saw
yours, so I did not Cc you.

Cheers,
peda