lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Dec 2016 22:03:19 -0600 From: Bin Liu <b-liu@...com> To: Pali Rohár <pali.rohar@...il.com> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Tony Lindgren <tony@...mide.com>, joerg Reisenweber <joerg@...nmoko.org>, <linux-omap@...r.kernel.org>, Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>, Sebastian Reichel <sre@...nel.org>, Aaro Koskinen <aaro.koskinen@....fi>, Pavel Machek <pavel@....cz>, Nishanth Menon <nm@...com>, Felipe Balbi <balbi@...nel.org> Subject: Re: [PATCH] usb: musb: debugfs: allow forcing host mode together with speed in testmode On Wed, Dec 14, 2016 at 08:23:45PM +0100, Pali Rohár wrote: > Based on the musb ug, force_host bit is allowed to be set along with > force_hs or force_fs bit. > > It could help to implement forced host mode via testmode on Nokia N900. > > Signed-off-by: Pali Rohár <pali.rohar@...il.com> > --- > drivers/usb/musb/musb_debugfs.c | 44 +++++++++++++++++++++++++-------------- > 1 file changed, 28 insertions(+), 16 deletions(-) > > diff --git a/drivers/usb/musb/musb_debugfs.c b/drivers/usb/musb/musb_debugfs.c > index 9b22d94..62c13a2 100644 > --- a/drivers/usb/musb/musb_debugfs.c > +++ b/drivers/usb/musb/musb_debugfs.c > @@ -147,28 +147,34 @@ static int musb_test_mode_show(struct seq_file *s, void *unused) > > test = musb_readb(musb->mregs, MUSB_TESTMODE); > > - if (test & MUSB_TEST_FORCE_HOST) > + if (test & (MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_FS)) if (test & (MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_FS) == MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_FS) or even simpler: if (test == MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_FS) since multiple tests at the same time are not allowed. > + seq_printf(s, "force host full-speed\n"); > + > + else if (test & (MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_HS)) else if (test == MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_HS) Regards, -Bin.
Powered by blists - more mailing lists