linux-kernel - Re: [PATCH 1/3] staging: android: remove ION_IOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 16 Dec 2016 23:27:08 +0000
From:   Matthew Smith <matthew.s3h@...il.com>
To:     Laura Abbott <labbott@...hat.com>
Cc:     greg@...ah.com, devel@...verdev.osuosl.org, arve@...roid.com,
        riandrews@...roid.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] staging: android: remove ION_IOC_SYNC

On Fri, Dec 16, 2016 at 03:05:54PM -0800, Laura Abbott wrote:
> The 'remove' from that TODO is more than just removing the code.
> There's also an implicit 'replace it with something else'. The
> work to do this is still ongoing (see some of my latest patches).
> NAK for all 3 of these patches right now.

Ah that makes a bit more sense.

> The patches themselves looked structurally good. For your commit
> message next time, explain why the code was being changed, not
> just what was changed.

Thank you for the advice, I'll remember that for next time :)