linux-kernel - Re: [PATCH 2/2] Input: i8042 - change dbg to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Dec 2016 16:54:45 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Marcos Paulo de Souza <marcos.souza.org@...il.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Input: i8042 - change dbg to pr_warn when returning
 errors

Hi Marcos,

On Tue, Dec 06, 2016 at 09:44:55PM -0200, Marcos Paulo de Souza wrote:
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@...il.com>
> ---
>  drivers/input/serio/i8042.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
> index 1c70747..bc54ce5 100644
> --- a/drivers/input/serio/i8042.c
> +++ b/drivers/input/serio/i8042.c
> @@ -323,13 +323,13 @@ static int __i8042_command(unsigned char *param, int command)
>  	for (i = 0; i < ((command >> 8) & 0xf); i++) {
>  		error = i8042_wait_read();
>  		if (error) {
> -			dbg("     -- i8042 (timeout)\n");
> +			pr_warn("     -- i8042 (timeout)\n");
>  			return error;
>  		}
>  
>  		if (command == I8042_CMD_AUX_LOOP &&
>  		    !(i8042_read_status() & I8042_STR_AUXDATA)) {
> -			dbg("     -- i8042 (auxerr)\n");
> +			pr_warn("     -- i8042 (auxerr)\n");
>  			return -1;

No, we expect this to fail on some systems (that is the whole point of
testing using the LOOP command to verify that AUX port is there and is
wired properly), so we should not be issuing warnings - the system way
very well be functioning properly.

dbg() is always there, so just rerun the boot with i8042.debug and get
all the trace needed.

Thanks.

-- 
Dmitry