linux-kernel - Re: [PATCH] scsi: esas2r: Fix format string type mistakes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <92483e45-c522-f7d5-e10d-9693d2675697@acm.org>
Date:   Sat, 17 Dec 2016 09:34:57 +0100
From:   Bart Van Assche <bart.vanassche@...il.com>
To:     Kees Cook <keescook@...omium.org>,
        Bradley Grove <linuxdrivers@...otech.com>
Cc:     linux-kernel@...r.kernel.org,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Emese Revfy <re.emese@...il.com>, linux-scsi@...r.kernel.org
Subject: Re: [PATCH] scsi: esas2r: Fix format string type mistakes

On 12/16/2016 10:50 PM, Kees Cook wrote:
> diff --git a/drivers/scsi/esas2r/esas2r_ioctl.c b/drivers/scsi/esas2r/esas2r_ioctl.c
> index 3e8483410f61..34976f9a1a10 100644
> --- a/drivers/scsi/esas2r/esas2r_ioctl.c
> +++ b/drivers/scsi/esas2r/esas2r_ioctl.c
> @@ -1301,7 +1301,7 @@ int esas2r_ioctl_handler(void *hostdata, int cmd, void __user *arg)
>  	ioctl = kzalloc(sizeof(struct atto_express_ioctl), GFP_KERNEL);
>  	if (ioctl == NULL) {
>  		esas2r_log(ESAS2R_LOG_WARN,
> -			   "ioctl_handler kzalloc failed for %d bytes",
> +			   "ioctl_handler kzalloc failed for %lu bytes",
>  			   sizeof(struct atto_express_ioctl));
>  		return -ENOMEM;
>  	}

Please use %zu to format size_t.

Bart.