linux-kernel - Re: [git pull] vfs.git pile 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwdh+VBdNY_gHc+CKMDznBwft+THQE9jBwfSojqOf72BQ@mail.gmail.com>
Date:   Sat, 17 Dec 2016 18:49:55 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [git pull] vfs.git pile 2

On Fri, Dec 16, 2016 at 2:12 PM, Al Viro <viro@...iv.linux.org.uk> wrote:
> In this pile:
>         * autofs-namespace series
>         * dedupe stuff
>         * more struct path constification

When looking at the conflict, I looked at that part of
vfs_clone_file_prep_inodes(), and reacted to the insanity.

WTF?

        /* Zero length dedupe exits immediately; reflink goes to EOF. */
        if (*len == 0) {
                if (is_dedupe) {
                        *len = 0;
                        return 0;
                }
                *len = isize - pos_in;
        }

I'll just leave you to read through that part a bit more. Because
there are two completely insane things going on in that code sequence.

                Linus