linux-kernel - Re: [PATCH] mm: simplify node/zone name printing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161219081210.GA32389@dhcp22.suse.cz>
Date:   Mon, 19 Dec 2016 09:12:10 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:     Vlastimil Babka <vbabka@...e.cz>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mel Gorman <mgorman@...e.de>,
        Johannes Weiner <hannes@...xchg.org>,
        Joonsoo Kim <js1304@...il.com>, linux-mm@...ck.org,
        LKML <linux-kernel@...r.kernel.org>,
        Petr Mladek <pmladek@...e.cz>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [PATCH] mm: simplify node/zone name printing

On Mon 19-12-16 16:32:28, Sergey Senozhatsky wrote:
[...]
> as far as I can tell, now for_each_populated_zone() iterations are
> split by non-CONT printk() from show_zone_node(), which previously
> has been   printk(KERN_CONT "%s: ", zone->name), so pr_cont(\n)
> between iterations was important, but now that non-CONT printk()
> should do the trick. it's _a bit_ hacky, though.

Do you consider that more hacky than the original? At least for me,
starting with KERN_CONT and relying on an explicit \n sounds more error
prone than leaving the last pr_cont without \n and relying on the
implicit flushing.
-- 
Michal Hocko
SUSE Labs