linux-kernel - Re: [PATCH 1/8] extcon: axp288: Remove dependency on non-existing platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3cd223a4-f4cc-4343-5ff9-5025d5be19e3@redhat.com>
Date:   Mon, 19 Dec 2016 09:18:41 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Chanwoo Choi <cw00.choi@...sung.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/8] extcon: axp288: Remove dependency on non-existing
 platform_data

Hi,

On 19-12-16 07:58, Chanwoo Choi wrote:
> Hi Hans,
>
> This series look good to me. I added the comment
> for patch4/5. If you agree following two comment, I'll merge these series for 4.11.
>
> - patch4 uses the EXTCON_NONE when setting the previous_cable in probe()
> - patch5, I don't want to use the dev_info on the fly. So, I want to drop the patch5.

Sounds good to me, thank you for reviewing these patches so quickly.

Regards,

Hans


>
> Regards,
> Chanwoo Choi
>
> On 2016년 12월 19일 15:10, Chanwoo Choi wrote:
>> Hi Hans,
>>
>> On 2016년 12월 19일 09:13, Hans de Goede wrote:
>>> When the extcon_axp288 driver was originally merged, it was merged with
>>> a dependency on some other driver providing platform data for it.
>>>
>>> However such another driver was never merged, so the extcon_axp288 as
>>> merged upstream has never worked, its probe method simply always returns
>>> -ENODEV.
>>>
>>> This commit drops the dependency on the pdata always being there, instead
>>> it treats not having pdata as the pdata having a NULL gpio_mux_control,
>>> something which the code was already prepared to handle.
>>>
>>> Note that the code for controlling the mux_control gpio is left in place,
>>> as this may be necessary to allow the axp288 pmic to properly detect the
>>> charger type (instead of assuming 500mA max charge current) on some
>>> tablets. This will make it easier for future patches to add support for
>>> this gpio by getting the gpio info from somewhere.
>>>
>>> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
>>> ---
>>>  drivers/extcon/extcon-axp288.c | 25 ++++++++++---------------
>>>  1 file changed, 10 insertions(+), 15 deletions(-)
>>
>> Looks good to me.
>> Acked-by: Chanwoo Choi <cw00.choi@...sung.com>
>>
>