linux-kernel - RE: [PATCH] USB3/DWC3: Enable undefined length INCR burst type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87shpke0nu.fsf@linux.intel.com>
Date:   Mon, 19 Dec 2016 11:19:33 +0200
From:   Felipe Balbi <balbi@...nel.org>
To:     Jerry Huang <jerry.huang@....com>,
        "gregkh\@linuxfoundation.org" <gregkh@...uxfoundation.org>
Cc:     "linux-usb\@vger.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        Rajesh Bhagat <rajesh.bhagat@....com>
Subject: RE: [PATCH] USB3/DWC3: Enable undefined length INCR burst type


Hi,

Jerry Huang <jerry.huang@....com> writes:
>> >> Jerry Huang <jerry.huang@....com> writes:
>> >> >> there's no need for that. This patch is in good format. I do have
>> >> >> a question,
>> >> >> however: how do you know this will work for all users? Burst size
>> >> >> is a function of how wide the interconnect where dwc3 is attached to,
>> is.
>> >> > So I need to generate one new property in usb node to identify my
>> >> platform?
>> >>
>> >> Well, we probably need a property to be passed, yes. But let's go
>> >> through it all first :-)
>> >
>> > I think "snps,quirk-frame-length-adjustment" is one good reference,
>> > which can pass the required value to driver from DTS file.
>> 
>> that's not for burst increment, though.
>
> I created one new property " snps,incr-burst-type-adjustment = <x>,
> <y>" to identify it from usb node, and will send out the v3 patch.

okay, don't forget to Cc devicetree@...r.kernel.org. Let's see what
those guys say.

>> > So, after enable undefined length INCR burst and enable INCR16,
>> > controller will use less than or equal to 16byte.
>> >
>> >> Only Undefined INCR will be taken into consideration. Can you check
>> >> with your HW engineers what's the largest burst the interconnect is
>> >> supposed to support?
>> > I will check it with IP designer.
>> 
>> cool, thanks :-)
>
> Have confirmed with hardware engineer, the maximum INCR burst size of
> NXP platform is 16 byte

good, thanks for that.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)