linux-kernel - Re: [PATCH] vfs: fix isize/pos/len checks for reflink & dedupe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161219101140.GA1796@infradead.org>
Date:   Mon, 19 Dec 2016 02:11:40 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     "Darrick J. Wong" <darrick.wong@...cle.com>
Cc:     Al Viro <viro@...IV.linux.org.uk>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH] vfs: fix isize/pos/len checks for reflink & dedupe

> +		else if (pos_in > isize)
> +			return -EINVAL;

No need for the else here.

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch@....de>