linux-kernel - [PATCH (resend)] seq_file: reset iterator to first record for zero offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161219113800.GE27207@veci.piliscsaba.szeredi.hu>
Date:   Mon, 19 Dec 2016 12:38:00 +0100
From:   Miklos Szeredi <miklos@...redi.hu>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Tomasz Majchrzak <tomasz.majchrzak@...el.com>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: [PATCH (resend)] seq_file: reset iterator to first record for zero
 offset

Al,

Can you please take (or NACK) this patch please?

Thanks,
Miklos

---
From: Tomasz Majchrzak <tomasz.majchrzak@...el.com>
Date: Tue, 29 Nov 2016 15:18:20 +0100

If kernfs file is empty on a first read, successive read operations
using the same file descriptor will return no data, even when data is
available. Default kernfs 'seq_next' implementation advances iterator
position even when next object is not there. Kernfs 'seq_start' for
following requests will not return iterator as position is already on
the second object.

This defect doesn't allow to monitor badblocks sysfs files from MD raid.
They are initially empty but if data appears at some stage, userspace is
not able to read it.

Signed-off-by: Tomasz Majchrzak <tomasz.majchrzak@...el.com>
Signed-off-by: Miklos Szeredi <mszeredi@...hat.com>
---
 fs/seq_file.c |    7 +++++++
 1 file changed, 7 insertions(+)

--- a/fs/seq_file.c
+++ b/fs/seq_file.c
@@ -190,6 +190,13 @@ ssize_t seq_read(struct file *file, char
 	 */
 	m->version = file->f_version;

+	/*
+	 * if request is to read from zero offset, reset iterator to first
+	 * record as it might have been already advanced by previous requests
+	 */
+	if (*ppos == 0)
+		m->index = 0;
+
 	/* Don't assume *ppos is where we left it */
 	if (unlikely(*ppos != m->read_pos)) {
 		while ((err = traverse(m, *ppos)) == -EAGAIN)