linux-kernel - linux-next: manual merge of the target-bva tree with Linus' tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20161219122850.246a698e@canb.auug.org.au>
Date:   Mon, 19 Dec 2016 12:28:50 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Bart Van Assche <bart.vanassche@...il.com>
Cc:     linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
        Al Viro <viro@...iv.linux.org.uk>
Subject: linux-next: manual merge of the target-bva tree with Linus' tree

Hi Bart,

Today's linux-next merge of the target-bva tree got a conflict in:

  drivers/target/target_core_configfs.c

between commit:

  450630975da9 ("don't open-code file_inode()")

from Linus' tree and commit:

  8cc3bb0789ea ("target: Use NULL instead of 0 to represent a pointer")

from the target-bva tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/target/target_core_configfs.c
index a35a347ec357,3bf6384c0f96..000000000000
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@@ -143,8 -143,8 +143,8 @@@ static ssize_t target_core_item_dbroot_
  		pr_err("db_root: cannot open: %s\n", db_root_stage);
  		return -EINVAL;
  	}
 -	if (!S_ISDIR(fp->f_inode->i_mode)) {
 +	if (!S_ISDIR(file_inode(fp)->i_mode)) {
- 		filp_close(fp, 0);
+ 		filp_close(fp, NULL);
  		mutex_unlock(&g_tf_lock);
  		pr_err("db_root: not a directory: %s\n", db_root_stage);
  		return -EINVAL;