linux-kernel - [PATCH] staging: comedi: dyna_pci10xx: fixed check patch warnings about memory barrier comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1482158175-3130-1-git-send-email-devendra.sharma9091@gmail.com>
Date:   Mon, 19 Dec 2016 20:06:15 +0530
From:   devendra sharma <devendra.sharma9091@...il.com>
To:     abbotti@....co.uk
Cc:     hsweeten@...ionengravers.com, gregkh@...uxfoundation.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        devendra sharma <devendra.sharma9091@...il.com>
Subject: [PATCH] staging: comedi: dyna_pci10xx: fixed check patch warnings about memory barrier comments

Added comments before memory barrier

Signed-off-by: Devendra Sharma <devendra.sharma9091@...il.com>
---
 drivers/staging/comedi/drivers/dyna_pci10xx.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c b/drivers/staging/comedi/drivers/dyna_pci10xx.c
index c9eb26f..c3b5236 100644
--- a/drivers/staging/comedi/drivers/dyna_pci10xx.c
+++ b/drivers/staging/comedi/drivers/dyna_pci10xx.c
@@ -122,6 +122,7 @@ static int dyna_pci10xx_insn_write_ao(struct comedi_device *dev,
 
 	mutex_lock(&devpriv->mutex);
 	for (n = 0; n < insn->n; n++) {
+		/*multi-processor memory barrier*/
 		smp_mb();
 		/* trigger conversion and write data */
 		outw_p(data[n], dev->iobase);
@@ -141,6 +142,7 @@ static int dyna_pci10xx_di_insn_bits(struct comedi_device *dev,
 	u16 d = 0;
 
 	mutex_lock(&devpriv->mutex);
+	/*multi-processor memory barrier*/
 	smp_mb();
 	d = inw_p(devpriv->BADR3);
 	udelay(10);
@@ -161,6 +163,7 @@ static int dyna_pci10xx_do_insn_bits(struct comedi_device *dev,
 
 	mutex_lock(&devpriv->mutex);
 	if (comedi_dio_update_state(s, data)) {
+		/*multi-processor memory barrier*/
 		smp_mb();
 		outw_p(s->state, devpriv->BADR3);
 		udelay(10);
-- 
2.7.4