linux-kernel - Re: [PATCH v4 3/4] KVM: x86: make interrupt delivery fast and slow path behave the same

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b1b2fcc5-5676-206f-af0a-7484fdcc69db@redhat.com>
Date:   Mon, 19 Dec 2016 15:57:16 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Radim Krčmář <rkrcmar@...hat.com>,
        Paolo Bonzini <pbonzini@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        Igor Mammedov <imammedo@...hat.com>
Subject: Re: [PATCH v4 3/4] KVM: x86: make interrupt delivery fast and slow
 path behave the same

Am 16.12.2016 um 18:07 schrieb Radim Krčmář:
> 2016-12-16 17:53+0100, Paolo Bonzini:
>> On 16/12/2016 17:41, David Hildenbrand wrote:
>>>
>>> Just to verify:
>>>
>>> The GET_APIC_DEST_FIELD(mda) == APIC_BROADCAST is still correct in
>>> kvm_apic_broadcast() ?
>>
>> No, it seems wrong.
>
> Definitely, sending v4 of this patch.
> I'll also add broadcast address check into kvm-unit-tests ...
> ---8<---
> Slow path tried to prevent IPIs from x2APIC VCPUs from being delivered
> to xAPIC VCPUs and vice-versa.  Make slow path behave like fast path,
> which never distinguished that.
>
> Signed-off-by: Radim Krčmář <rkrcmar@...hat.com>
> ---
>  v4: fix xAPIC broadcast address detection [David]
> ---
>  arch/x86/kvm/lapic.c | 20 ++++++++------------
>  1 file changed, 8 insertions(+), 12 deletions(-)
>

Looks good to me.

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 

David