linux-kernel - Re: [PATCH 1/2] ASoC: rt5660: Add ACPI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161219154428.qedy4fxmtsvownvh@sirena.org.uk>
Date:   Mon, 19 Dec 2016 15:44:28 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Shrirang Bagul <shrirang.bagul@...onical.com>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        Bard Liao <bardliao@...ltek.com>,
        Oder Chiou <oder_chiou@...ltek.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH 1/2] ASoC: rt5660: Add ACPI support

On Mon, Dec 19, 2016 at 09:51:46PM +0800, Shrirang Bagul wrote:

> +static const struct acpi_gpio_params audio_wake_intr_gpio = { 0, 0, false };
> +static const struct acpi_gpio_params lineout_mute_gpio = { 1, 0, true };

Can we please write these in a fashion more idiomatic for the kernel and
useful for human readers with named struct fields?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)