linux-kernel - Re: [PATCH 1/1] xfs: silent -Wformat-security warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Dec 2016 08:05:44 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Nicolas Iooss <nicolas.iooss_linux@....org>
Cc:     Dave Chinner <david@...morbit.com>, linux-xfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] xfs: silent -Wformat-security warning

On Mon, Dec 19, 2016 at 02:41:11PM +0100, Nicolas Iooss wrote:
> When building the XFS driver with clang, the compiler reports a
> -Wformat-security warning in xlog_recover_validate_buf_type() because
> xfs_warn() is being called with a non-literal string. Even though
> variable warnmsg is always initialized as a constant string without any
> '%' character, silent the warning by calling xfs_warn with "%s" format
> string.
> 
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@....org>

Looks fine:

Reviewed-by: Christoph Hellwig <hch@....de>