linux-kernel - Re: [PATCH v2] staging: lustre: Fix variable type declaration after refactoring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Dec 2016 16:38:44 +0000 (GMT)
From:   James Simmons <jsimmons@...radead.org>
To:     Quentin Lambert <lambert.quentin@...il.com>
cc:     Oleg Drokin <oleg.drokin@...el.com>,
        Andreas Dilger <andreas.dilger@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        lustre-devel@...ts.lustre.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] staging: lustre: Fix variable type declaration after
 refactoring


> A recent clean-up declared och_flags as a int rather than fmode_t. This
> lead to the following sparse warning:
> 
> drivers/staging/lustre/lustre/llite/file.c:106:30: warning: restricted
> fmode_t degrades to integer
> 
> This patch fixes this issue.

Acked-by: James Simmons <jsimmons@...radead.org>
 
> Fixes: 0a1200991234f7 ("staging: lustre: cleanup lustre_lib.h")
> Signed-off-by: Quentin Lambert <lambert.quentin@...il.com>
> ---
>  v2: fixes the referenced sha
> 
>  drivers/staging/lustre/lustre/include/obd.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/staging/lustre/lustre/include/obd.h
> +++ b/drivers/staging/lustre/lustre/include/obd.h
> @@ -889,7 +889,7 @@ struct obd_client_handle {
>  	struct md_open_data	*och_mod;
>  	struct lustre_handle	 och_lease_handle; /* open lock for lease */
>  	__u32			 och_magic;
> -	int			 och_flags;
> +	fmode_t			 och_flags;
>  };
>  
>  #define OBD_CLIENT_HANDLE_MAGIC 0xd15ea5ed
>