linux-kernel - Re: [alsa-devel] [PATCH 2/2] ASoC: Intel: boards: Add Baytrail RT5660 machine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161219164402.g4knszgpgowfxelb@sirena.org.uk>
Date:   Mon, 19 Dec 2016 16:44:02 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Cc:     Shrirang Bagul <shrirang.bagul@...onical.com>,
        alsa-devel@...a-project.org,
        Jorge Fernandez Monteagudo <jorgefm@...sa.com>,
        Arnd Bergmann <arnd@...db.de>,
        Liam Girdwood <lgirdwood@...il.com>,
        Vinod Koul <vinod.koul@...el.com>,
        linux-kernel@...r.kernel.org, Takashi Iwai <tiwai@...e.com>,
        Ramesh Babu <ramesh.babu@...el.com>,
        Ben Zhang <benzh@...omium.org>,
        John Keeping <john@...anate.com>,
        Sathyanarayana Nujella <sathyanarayana.nujella@...el.com>,
        Colin Ian King <colin.king@...onical.com>,
        Jeeja KP <jeeja.kp@...el.com>
Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: Intel: boards: Add Baytrail
 RT5660 machine driver

On Mon, Dec 19, 2016 at 10:30:09AM -0600, Pierre-Louis Bossart wrote:

> All this code seems to be largely a copy-paste of the bytcr_rt5640 machine
> driver and the same comments would apply there. This patch did miss the last

Yes, there's a lot of room for cleanups in the existing code too (and of
course if there's such a large amount of cut'n'paste that implies that
there should be some code reuse going on).

> correction merged by Mark to deal with errors "ASoC: Intel: bytcr_rt5640:
> fallback mechanism if MCLK is not enabled" and the same error handling would
> be needed.

There was a cut back version of it I thought?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)