linux-kernel - Re: [PATCH] staging: comedi: cb_pcidas64: Fixed coding issue about multiple line dereferencing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58582328.2070503@mev.co.uk>
Date:   Mon, 19 Dec 2016 18:12:56 +0000
From:   Ian Abbott <abbotti@....co.uk>
To:     devendra sharma <devendra.sharma9091@...il.com>
CC:     hsweeten@...ionengravers.com, gregkh@...uxfoundation.org,
        ansonjacob.aj@...il.com, amitoj1606@...il.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: cb_pcidas64: Fixed coding issue about
 multiple line dereferencing

On 19/12/2016 15:14, devendra sharma wrote:
> Fixed coding issue about multiple line dereferencing
>
> Signed-off-by: Devendra Sharma <devendra.sharma9091@...il.com>
> ---
>   drivers/staging/comedi/drivers/cb_pcidas64.c | 13 +++++--------
>   1 file changed, 5 insertions(+), 8 deletions(-)
>

I guess this is version 3 of the patch?

> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
> index cb9c269..9ace9c0 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidas64.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
> @@ -2475,20 +2475,17 @@ static int setup_channel_queue(struct comedi_device *dev,
>   			/* load external queue */
>   			for (i = 0; i < cmd->chanlist_len; i++) {
>   				bits = 0;
> +				unsigned int ch = cmd->chanlist[i];

Please put all declarations within a block before any statements in the 
block (in other words, avoid mixing declarations with code), and use a 
blank line to separate the declarations from the statements.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-