linux-kernel - Re: [PATCH] ASoC: wm_adsp: Don't overrun firmware file buffer when reading region data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201612200338.TLYOtSof%fengguang.wu@intel.com>
Date:   Tue, 20 Dec 2016 03:16:53 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
Cc:     kbuild-all@...org, broonie@...nel.org,
        linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
        patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: wm_adsp: Don't overrun firmware file buffer when
 reading region data

Hi Richard,

[auto build test WARNING on asoc/for-next]
[also build test WARNING on v4.9 next-20161219]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Richard-Fitzgerald/ASoC-wm_adsp-Don-t-overrun-firmware-file-buffer-when-reading-region-data/20161220-021733
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: tile-allmodconfig (attached as .config)
compiler: tilegx-linux-gcc (GCC) 4.6.2
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=tile 

All warnings (new ones prefixed by >>):

   sound/soc/codecs/wm_adsp.c: In function 'wm_adsp_load':
>> sound/soc/codecs/wm_adsp.c:1705:4: warning: format '%d' expects argument of type 'int', but argument 8 has type 'size_t' [-Wformat]
   sound/soc/codecs/wm_adsp.c: In function 'wm_adsp_load_coeff':
   sound/soc/codecs/wm_adsp.c:2250:5: warning: format '%d' expects argument of type 'int', but argument 8 has type 'size_t' [-Wformat]

vim +1705 sound/soc/codecs/wm_adsp.c

  1689				region_name = wm_adsp_mem_region_name(type);
  1690				reg = wm_adsp_region_to_reg(mem, offset);
  1691				break;
  1692			default:
  1693				adsp_warn(dsp,
  1694					  "%s.%d: Unknown region type %x at %d(%x)\n",
  1695					  file, regions, type, pos, pos);
  1696				break;
  1697			}
  1698	
  1699			adsp_dbg(dsp, "%s.%d: %d bytes at %d in %s\n", file,
  1700				 regions, le32_to_cpu(region->len), offset,
  1701				 region_name);
  1702	
  1703			if ((pos + le32_to_cpu(region->len) + sizeof(*region)) >
  1704			    firmware->size) {
> 1705				adsp_err(dsp,
  1706					 "%s.%d: %s region len %d bytes exceeds file length %d\n",
  1707					 file, regions, region_name,
  1708					 le32_to_cpu(region->len), firmware->size);
  1709				ret = -EINVAL;
  1710				goto out_fw;
  1711			}
  1712	
  1713			if (text) {

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (46374 bytes)