linux-kernel - Re: [PATCH] drm/vmwgfx: use designated initializers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161219221344.GA33820@promb-2n-dhcp338.eng.vmware.com>
Date:   Mon, 19 Dec 2016 14:13:45 -0800
From:   Sinclair Yeh <syeh@...are.com>
To:     Kees Cook <keescook@...omium.org>
CC:     <linux-kernel@...r.kernel.org>,
        VMware Graphics <linux-graphics-maintainer@...are.com>,
        Thomas Hellstrom <thellstrom@...are.com>,
        David Airlie <airlied@...ux.ie>,
        <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/vmwgfx: use designated initializers

Reviewed-by: Sinclair Yeh <syeh@...are.com>

thanks!

On Fri, Dec 16, 2016 at 05:04:02PM -0800, Kees Cook wrote:
> Prepare to mark sensitive kernel structures for randomization by making
> sure they're using designated initializers. These were identified during
> allyesconfig builds of x86, arm, and arm64, with most initializer fixes
> extracted from grsecurity.
> 
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c b/drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c
> index 170b61be1e4e..fec7348cea2c 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c
> @@ -164,9 +164,9 @@ static void vmw_gmrid_man_debug(struct ttm_mem_type_manager *man,
>  }
>  
>  const struct ttm_mem_type_manager_func vmw_gmrid_manager_func = {
> -	vmw_gmrid_man_init,
> -	vmw_gmrid_man_takedown,
> -	vmw_gmrid_man_get_node,
> -	vmw_gmrid_man_put_node,
> -	vmw_gmrid_man_debug
> +	.init = vmw_gmrid_man_init,
> +	.takedown = vmw_gmrid_man_takedown,
> +	.get_node = vmw_gmrid_man_get_node,
> +	.put_node = vmw_gmrid_man_put_node,
> +	.debug = vmw_gmrid_man_debug
>  };
> -- 
> 2.7.4
> 
> 
> -- 
> Kees Cook
> Nexus Security