linux-kernel - [tip:x86/urgent] x86/platform/intel/quark: Add printf attribute to imr_self_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-9120cf4fd9ae77245ce9137869bcbd16575cc633@git.kernel.org>
Date:   Tue, 20 Dec 2016 01:36:12 -0800
From:   tip-bot for Nicolas Iooss <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     tglx@...utronix.de, nicolas.iooss_linux@....org, mingo@...nel.org,
        peterz@...radead.org, hpa@...or.com, linux-kernel@...r.kernel.org,
        pure.logic@...us-software.ie, torvalds@...ux-foundation.org
Subject: [tip:x86/urgent] x86/platform/intel/quark: Add printf attribute to
 imr_self_test_result()

Commit-ID:  9120cf4fd9ae77245ce9137869bcbd16575cc633
Gitweb:     http://git.kernel.org/tip/9120cf4fd9ae77245ce9137869bcbd16575cc633
Author:     Nicolas Iooss <nicolas.iooss_linux@....org>
AuthorDate: Mon, 19 Dec 2016 14:21:44 +0100
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Tue, 20 Dec 2016 09:37:24 +0100

x86/platform/intel/quark: Add printf attribute to imr_self_test_result()

__printf() attributes help detecting issues in printf() format strings at
compile time.

Even though imr_selftest.c is only compiled with
CONFIG_DEBUG_IMR_SELFTEST=y, GCC complains about a missing format
attribute when compiling allmodconfig with -Wmissing-format-attribute.

Silence this warning by adding the attribute.

Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@....org>
Acked-by: Bryan O'Donoghue <pure.logic@...us-software.ie>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Link: http://lkml.kernel.org/r/20161219132144.4108-1-nicolas.iooss_linux@m4x.org
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/platform/intel-quark/imr_selftest.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/platform/intel-quark/imr_selftest.c b/arch/x86/platform/intel-quark/imr_selftest.c
index f5bad40..b8f5620 100644
--- a/arch/x86/platform/intel-quark/imr_selftest.c
+++ b/arch/x86/platform/intel-quark/imr_selftest.c
@@ -25,7 +25,8 @@
  * @fmt:	format string.
  * ...		variadic argument list.
  */
-static void __init imr_self_test_result(int res, const char *fmt, ...)
+static __printf(2, 3)
+void __init imr_self_test_result(int res, const char *fmt, ...)
 {
 	va_list vlist;