linux-kernel - Re: [PATCH 1/1] kernel: futex: fixed to else and initcall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Dec 2016 11:39:43 +0200
From:   Ozgur Karatas <okaratas@...ber.fsf.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     "dave@...olabs.net" <dave@...olabs.net>,
        "dvhart@...ux.intel.com" <dvhart@...ux.intel.com>,
        "bigeasy@...utronix.de" <bigeasy@...utronix.de>,
        "mgorman@...e.de" <mgorman@...e.de>,
        "dingel@...ux.vnet.ibm.com" <dingel@...ux.vnet.ibm.com>,
        "kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1] kernel: futex: fixed to else and initcall

20.12.2016, 11:21, "Thomas Gleixner" <tglx@...utronix.de>:
> On Mon, 19 Dec 2016, Ozgur Karatas wrote:
>
>>  else doesn't need to be used, if should be enclosed in parentheses.
>
> Really?
>
>
> So you change the code from
>
>         if (err < 0)
>                 return err;
>             else
>                 err = 0;
>
> to
>
>         if (err < 0) {
>                 return err;
>                 err = 0;
>         }
>
> How on earth is that equivivalent and how would that 'err = 0;' statement
> be ever executed?

Oh my god, I missed this point, sorry! 
Thank you so much for correct me.

This "return err;" will give to "err" and err defined to err = "0".
Then removed to "else" and return = err;  and should it be like this?

#define err = 0;

         if (err < 0) {
                 return err;
         }

Regards,

Ozgur

> You clearly ran checkpatch.pl on this file and the output for this
> construct is:
>
> WARNING: else is not generally useful after a break or return
> #550: FILE: kernel/futex.c:550:
> + return err;
> + else
>
> So the proper change would have been:
>
>         if (err < 0)
>                 return err;
>
>         err = 0;
>
> and not the trainwreck you created.
>
> checkpatch.pl does not substitute basic knowlegde of C.
>
> Thanks,
>
>         tglx