linux-kernel - Re: [PATCH] sched/fair: fix calc_cfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cfa3d75d-b0b4-a785-7a24-3d6720e697bb@arm.com>
Date:   Tue, 20 Dec 2016 14:04:34 +0100
From:   Dietmar Eggemann <dietmar.eggemann@....com>
To:     Samuel Thibault <samuel.thibault@...-lyon.org>,
        Paul Turner <pjt@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH] sched/fair: fix calc_cfs_shares fixed point arithmetics

Hi Samuel,

On 12/20/2016 12:45 AM, Samuel Thibault wrote:
> Paul Turner, on Mon 19 Dec 2016 15:32:15 -0800, wrote:
>> On Mon, Dec 19, 2016 at 3:29 PM, Samuel Thibault
>> <samuel.thibault@...-lyon.org> wrote:
>>> Paul Turner, on Mon 19 Dec 2016 15:26:19 -0800, wrote:

[...]

>> The MIN_SHARES you are seeing here is overloaded.
>> In the unscaled case this needs to be MIN_SHARES, and in the scaled
>> case, the subdivision of the scaled values must still be >=2.
>
> Ok, now I understand.  I have to say this overloading is confusing.
>
> Samuel

this had been already discussed back in August when I posted the 
original patch.


https://lkml.org/lkml/2016/8/22/351
https://lkml.org/lkml/2016/8/23/641