linux-kernel - Re: [PATCH v6] soc: qcom: Add SoC info driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161220225007.GD5423@codeaurora.org>
Date:   Tue, 20 Dec 2016 14:50:07 -0800
From:   Stephen Boyd <sboyd@...eaurora.org>
To:     Imran Khan <kimran@...eaurora.org>
Cc:     andy.gross@...aro.org, lee.jones@...aro.org,
        David Brown <david.brown@...aro.org>,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-soc@...r.kernel.org
Subject: Re: [PATCH v6] soc: qcom: Add SoC info driver

On 12/18, Imran Khan wrote:
> 
> I had discussed this with Bjorn and it was recommended to keep it out of 
> smem.h. If needed I can move it back there.

Ok no worries from me then if this has already been discussed.

> 
> Yes. The numbers used here can have different meaning for different ODMs.
> But these attributes (hw_patform type/subtype etc.) are outside the
> generic soc_device_attribute so I think the interpretation of these numbers
> can very well be ODM specific. We can try to keep only those types here that
> are relevant for newer platforms but we intend to keep these attributes
> nonetheless.

I'll wait to see what the next patch version has. We will
probably need to have some way to know which ODM the kernel is
running on, so we can interpret the platform type/subtype fields
properly. That part seems to be lacking from this patch right
now. We assume it's always qcom as the ODM, which isn't true.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project