lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 21 Dec 2016 10:22:37 +0800
From:   Baolin Wang <>
To:     Mathias Nyman <>
Cc:     Lu Baolu <>,
        Mathias Nyman <>,
        Greg KH <>,
        USB <>,
        LKML <>,
        Mark Brown <>,
        "Lu, Baolu" <>
Subject: Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

Hi Mathias,

On 20 December 2016 at 23:13, Mathias Nyman
<> wrote:
> On 20.12.2016 09:30, Baolin Wang wrote:
> ...
> Alright, I gathered all current work related to xhci races and timeouts
> and put them into a branch:
> git://
> timeout_race_fixes
> Its based on 4.9
> It includes a few other patches just to avoid conflicts and  make my life
> easier
> Interesting patches are:
> ee4eb91 xhci: remove unnecessary check for pending timer
> 0cba67d xhci: detect stop endpoint race using pending timer instead of
> counter.
> 4f2535f xhci: Handle command completion and timeout race
> b9d00d7 usb: host: xhci: Fix possible wild pointer when handling abort
> command
> 529a5a0 usb: xhci: fix possible wild pointer
> 4766555 xhci: Fix race related to abort operation
> de834a3 xhci: Use delayed_work instead of timer for command timeout
> 69973b8 Linux 4.9
> The fixes for command queue races will go to usb-linus and stable, the
> reworks for stop ep watchdog timer will go to usb-next.

How about applying below patch in your 'timeout_race_fixes' branch?
[PATCH] usb: host: xhci: Clean up commands when stop endpoint command is timeout

> Still completely untested, (well it compiles)
> Felipe gave instructions how to modify dwc3 driver to timeout on address
> devicecommands to test these, I'll try to set that up.
> All additional testing is welcome, especially if you can trigger timeouts
> and races

I will try to test these patches.

Best Regards

Powered by blists - more mailing lists