linux-kernel - Re: [PATCH] pci: add kernel config option for disabling common PCI quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161221122213.GA32563@infradead.org>
Date:   Wed, 21 Dec 2016 04:22:13 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     John Crispin <john@...ozen.org>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, Gabor Juhos <juhosg@...nwrt.org>
Subject: Re: [PATCH] pci: add kernel config option for disabling common PCI
 quirks

On Wed, Dec 21, 2016 at 08:53:04AM +0100, John Crispin wrote:
> This patch has been lingering inside the OpenWrt for some years. I am not
> sure if this is the best way to remove the quirks from the build. Let me
> know if you prefer a different way of solving this.

As a start negative options (_DISABLE_) are very confusing, I would
recommend to turn this into a postive option with a default y.

On what grounds did you decide which quirks to keep and which to
remove?