linux-kernel - Re: at86rf230: Allow slow GPIO pins for "rstn"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1482323452-10642-1-git-send-email-nikita.yoush@cogentembedded.com>
Date:   Wed, 21 Dec 2016 15:30:52 +0300
From:   Nikita Yushchenko <nikita.yoush@...entembedded.com>
To:     linux-wpan@...r.kernel.org
Cc:     Andrey Smirnov <andrew.smirnov@...il.com>,
        Alexander Aring <aar@...gutronix.de>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Chris Healy <cphealy@...il.com>,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>
Subject: Re: at86rf230: Allow slow GPIO pins for "rstn"

> Driver code never touches "rstn" signal in atomic context, so there's
> no need to implicitly put such restriction on it by using gpio_set_value
> to manipulate it. Replace gpio_set_value to gpio_set_value_cansleep to
> fix that.
> 
> As a an example of where such restriction might be inconvenient,
> consider a hardware design where "rstn" is connected to a pin of I2C/SPI
> GPIO expander chip.
> 
> Cc: Chris Healy <cphealy@...il.com>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>

Reviewed-by: Nikita Yushchenko <nikita.yoush@...entembedded.com>